Skip to content

Feature/5566 maintenance contract #61

Closed
turegjorup wants to merge 46 commits into
developfrom
feature/5566_maintenance_contract-
Closed

Feature/5566 maintenance contract #61
turegjorup wants to merge 46 commits into
developfrom
feature/5566_maintenance_contract-

Conversation

@turegjorup
Copy link
Copy Markdown
Contributor

@turegjorup turegjorup commented Oct 22, 2025

Link to ticket

https://leantime.itkdev.dk/ProjectOverview/projectOverview?fromDate=2025-01-01&userIds=14&tab=ticketdetails#/tickets/showTicket/5566

Depends on: #60

Description

  • Add security contract entity with crud controller
  • Add Abstract full crud controller and extend on it in some cases
  • Add economics service and sync action/command for service agreement synchronization

!Note: Due to multiple iterations of this feature in this branch the autogenerated migrations are a little too comprehensive compared to the actual end result.

Screenshot of the result

List:
Skærmbillede 2026-05-19 kl  11 00 27

Detail:
Skærmbillede 2026-05-19 kl  11 00 43

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@turegjorup turegjorup self-assigned this Oct 22, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 22, 2025

API Specification - Non-breaking changes

API Changelog 1.0.0 vs. 1.0.0

No changes detected

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 39.45312% with 310 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@8126bb9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Entity/SecurityContract.php 0.00% 107 Missing ⚠️
...ontroller/Admin/SecurityContractCrudController.php 5.17% 55 Missing ⚠️
src/Service/ServiceAgreementSyncService.php 1.88% 52 Missing ⚠️
src/Doctrine/Functions/SemverNumeric.php 0.00% 22 Missing ⚠️
src/Form/Type/Admin/SemverFilterType.php 0.00% 19 Missing ⚠️
...rc/EasyAdmin/Config/Menu/AutoBadgeCrudMenuItem.php 0.00% 14 Missing ⚠️
src/Command/SyncServiceAgreementsCommand.php 0.00% 10 Missing ⚠️
src/Repository/SecurityContractRepository.php 0.00% 10 Missing ⚠️
src/Repository/OIDCRepository.php 0.00% 7 Missing ⚠️
src/Repository/ServiceCertificateRepository.php 0.00% 7 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #61   +/-   ##
==========================================
  Coverage           ?   37.14%           
  Complexity         ?      948           
==========================================
  Files              ?      133           
  Lines              ?     2972           
  Branches           ?        0           
==========================================
  Hits               ?     1104           
  Misses             ?     1868           
  Partials           ?        0           
Flag Coverage Δ
unittests 37.14% <39.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martinyde martinyde assigned martinyde and unassigned turegjorup May 19, 2026
@martinyde martinyde closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants